Skip to content

feat(winget): Add additional template values #5714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 21, 2025
Merged

feat(winget): Add additional template values #5714

merged 5 commits into from
Apr 21, 2025

Conversation

elousiv
Copy link
Contributor

@elousiv elousiv commented Apr 10, 2025 •
edited
Loading

Updates winget templated yaml files as follows:

Adds the following to the locale

  • PrivacyURL
  • InstallationNotes

This change is being made so some users who migrated to goreleaser do not have to manually add fields which aren't currently supported after each release.

microsoft/winget-pkgs#246804

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 10, 2025
@elousiv elousiv force-pushed the task/winget-template-updates branch from 3928f28 to 1c4f616 Compare April 10, 2025 16:19
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 10, 2025
@elousiv elousiv force-pushed the task/winget-template-updates branch from 1c4f616 to 06093ce Compare April 10, 2025 16:21
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 10, 2025
@elousiv elousiv force-pushed the task/winget-template-updates branch from 06093ce to 6a42861 Compare April 10, 2025 16:23
@pull-request-size pull-request-size bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 10, 2025
caarlos0
caarlos0 approved these changes Apr 11, 2025
View reviewed changes
Copy link
Member

@caarlos0 caarlos0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, this looks good, thank you!

could you add these to winget.md as well?

@elousiv elousiv force-pushed the task/winget-template-updates branch from 116414c to 09277a6 Compare April 18, 2025 14:11
@elousiv elousiv requested a review from caarlos0 April 18, 2025 15:43
caarlos0
caarlos0 reviewed Apr 21, 2025
View reviewed changes
@caarlos0 caarlos0 added the enhancement New feature or request label Apr 21, 2025
@elousiv elousiv requested a review from caarlos0 April 21, 2025 14:29
@caarlos0
Copy link
Member

I think we'll need to run go test ./internal/pipe/winget/... -update to fix the build

I'll do it :)

thanks again for the PR!

@caarlos0 caarlos0 merged commit bc50e7e into goreleaser:main Apr 21, 2025
10 of 14 checks passed
@elousiv elousiv deleted the task/winget-template-updates branch April 21, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caarlos0 caarlos0 Awaiting requested review from caarlos0

Assignees
No one assigned
Labels
enhancement New feature or request size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elousiv @caarlos0