feat: warn about repeated uploadable artifact names #5713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
internal/artifact/artifact_test.go:1030
- [nitpick] Consider refactoring the loop into a table-driven test to clearly specify expected behavior for each artifact type, which may improve readability and scalability of the tests.
for i := 1; i <= 30; i++ {
| @@ -468,11 +477,20 @@ func (artifacts *Artifacts) Add(a *Artifact) { | |||
| } | |||
| } | |||
| a.Path = filepath.ToSlash(a.Path) | |||
| if a.Type.isUploadable() && | |||
There was a problem hiding this comment.
The warning log message for duplicate uploadable artifact names could be clarified to indicate that the artifact is still being added and that this is just a warning. Consider rewording it for clearer remediation guidance.
Copilot uses AI. Check for mistakes.
Deploying goreleaser with
|
| Latest commit: |
6c3e43b
|
| Status: | ⚡️ Build in progress... |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5713 +/- ##
==========================================
+ Coverage 83.01% 83.02% +0.01%
==========================================
Files 158 158
Lines 15564 15579 +15
==========================================
+ Hits 12920 12935 +15
Misses 2088 2088
Partials 556 556 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs https://github.com/orgs/goreleaser/discussions/5682#discussioncomment-12640596