fix(nix): use nix-hash instead of nix-prefetch-url #5669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`nix-prefetch-url` will need the release to be published to work. If the user wants to start the release as a draft and publish manually, this will fail, as the URL will fail to resolve. Using `nix-hash` instead is also faster than `nix-prefetch-url`, as it doesn't need to download the artifact again.
Deploying goreleaser with
|
| Latest commit: |
90111f0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7a195aa5.goreleaser.pages.dev |
| Branch Preview URL: | https://nix.goreleaser.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5669 +/- ##
=======================================
Coverage 82.84% 82.85%
=======================================
Files 156 156
Lines 15612 15617 +5
=======================================
+ Hits 12934 12939 +5
Misses 2111 2111
Partials 567 567 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
caarlos0
added a commit
that referenced
this pull request
Mar 22, 2025
refs #5669 Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nix-prefetch-urlwill need the release to be published to work.If the user wants to start the release as a draft and publish manually, this will fail, as the URL will fail to resolve.
Using
nix-hashinstead is also faster thannix-prefetch-url, as it doesn't need to download the artifact again.