Skip to content

fix(winget): make tags lowercase #5664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 22, 2025
Merged

fix(winget): make tags lowercase #5664

merged 4 commits into from
Mar 22, 2025

Conversation

vedantmgoyal9
Copy link
Member

No description provided.

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 21, 2025
@vedantmgoyal9 vedantmgoyal9 requested a review from caarlos0 March 21, 2025 11:15
Copy link

cloudflare-workers-and-pages bot commented Mar 21, 2025

Deploying goreleaser with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5dd1a47
Status: ✅  Deploy successful!
Preview URL: https://a634678e.goreleaser.pages.dev
Branch Preview URL: https://winget-tags-lowercase.goreleaser.pages.dev

View logs

Copy link

codecov bot commented Mar 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.84%. Comparing base (0cb58bf) to head (5dd1a47).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5664   +/-   ##
=======================================
  Coverage   82.84%   82.84%           
=======================================
  Files         156      156           
  Lines       15612    15612           
=======================================
  Hits        12934    12934           
  Misses       2111     2111           
  Partials      567      567           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@caarlos0 caarlos0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add it to a test as well?

Can add to an existing test and run go test -update on the winget pkg

@caarlos0 caarlos0 added the bug Something isn't working label Mar 22, 2025
@caarlos0 caarlos0 merged commit 5b9edcb into main Mar 22, 2025
18 of 19 checks passed
@caarlos0 caarlos0 deleted the winget-tags-lowercase branch March 22, 2025 14:06
@caarlos0
Copy link
Member

awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants