Skip to content

fix(winget): better handle publisher name #5643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 21, 2025
Merged

fix(winget): better handle publisher name #5643

merged 3 commits into from
Mar 21, 2025

Conversation

caarlos0
Copy link
Member

  • use package identifier for the filename if set
  • properly build the package identifier if not set

@caarlos0 caarlos0 added the bug Something isn't working label Mar 13, 2025
@caarlos0 caarlos0 self-assigned this Mar 13, 2025
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 13, 2025
@caarlos0 caarlos0 requested a review from vedantmgoyal9 March 13, 2025 13:27
@codecov Codecov
Copy link

codecov bot commented Mar 13, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.84%. Comparing base (0ec35e8) to head (a5df06c).
Report is 30 commits behind head on main.

Files with missing lines Patch % Lines
internal/pipe/winget/winget.go 85.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5643   +/-   ##
=======================================
  Coverage   82.83%   82.84%           
=======================================
  Files         156      156           
  Lines       15585    15607   +22     
=======================================
+ Hits        12910    12929   +19     
- Misses       2109     2111    +2     
- Partials      566      567    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Mar 13, 2025 •
edited
Loading

Deploying goreleaser with  Cloudflare Pages  Cloudflare Pages

Latest commit: a5df06c
Status: ✅  Deploy successful!
Preview URL: https://b118027c.goreleaser.pages.dev
Branch Preview URL: https://winget-pkg-id.goreleaser.pages.dev

View logs

vedantmgoyal9
vedantmgoyal9 reviewed Mar 15, 2025
View reviewed changes
Copy link
Member

@vedantmgoyal9 vedantmgoyal9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Fix spaces in Commands, e.g. microsoft/winget-pkgs#233843.
  2. Automatically fix tags as per recommended best practices -
    image

@caarlos0
Copy link
Member Author

The commands come from the binary names... we can't simply remove the spaces I'm afraid.

@vedantmgoyal9
Copy link
Member

The commands come from the binary names... we can't simply remove the spaces I'm afraid.

my bad, i didn't see the previous commit. previously, it used to be project_name.

@caarlos0
fix: spaces
a5df06c 
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 merged commit 41d529a into main Mar 21, 2025
18 checks passed
@caarlos0 caarlos0 deleted the winget-pkg-id branch March 21, 2025 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vedantmgoyal9 vedantmgoyal9 vedantmgoyal9 approved these changes

Assignees

@caarlos0 caarlos0

Labels
bug Something isn't working size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caarlos0 @vedantmgoyal9