Skip to content

fix: notify each deprecation only once #5642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 13, 2025
Merged

fix: notify each deprecation only once #5642

merged 4 commits into from
Mar 13, 2025

Conversation

caarlos0
Copy link
Member

this will store previously notified deprecations, and not notify them again.

@caarlos0 caarlos0 added the bug Something isn't working label Mar 13, 2025
@caarlos0 caarlos0 self-assigned this Mar 13, 2025
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 13, 2025
Copy link

cloudflare-workers-and-pages bot commented Mar 13, 2025

Deploying goreleaser with  Cloudflare Pages  Cloudflare Pages

Latest commit: e20cd8c
Status: ✅  Deploy successful!
Preview URL: https://69a4ef48.goreleaser.pages.dev
Branch Preview URL: https://notif-deprecations.goreleaser.pages.dev

View logs

Copy link

codecov bot commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.84%. Comparing base (e169c69) to head (e20cd8c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5642   +/-   ##
=======================================
  Coverage   82.83%   82.84%           
=======================================
  Files         156      156           
  Lines       15585    15592    +7     
=======================================
+ Hits        12910    12917    +7     
  Misses       2109     2109           
  Partials      566      566           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 merged commit f9bc1ca into main Mar 13, 2025
18 checks passed
@caarlos0 caarlos0 deleted the notif-deprecations branch March 13, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant