-
-
Notifications
You must be signed in to change notification settings - Fork 1k
feat(archive): allow to specify multiple formats #5455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pluralize `format` and allow create multiple archives with the same configuration. Also allow to override the formats for a GOOS. Closes #5436
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Deploying goreleaser with
|
Latest commit: |
e7bf67f
|
Status: | ✅ Deploy successful! |
Preview URL: | https://c6bb4fef.goreleaser.pages.dev |
Branch Preview URL: | https://archive-formats.goreleaser.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5455 +/- ##
==========================================
- Coverage 82.86% 82.78% -0.09%
==========================================
Files 157 157
Lines 15368 15381 +13
==========================================
- Hits 12735 12733 -2
- Misses 2081 2091 +10
- Partials 552 557 +5 ☔ View full report in Codecov by Sentry. |
Awesome, didn't expect this to materialize so quickly! I just gave it a try, and it works nicely and behaves exactly as I'd expect. |
This can only be merged once goreleaser/goreleaser#5455 is release officially
This can only be merged once goreleaser/goreleaser#5455 is released officially.
Just out of curiosity: why does the |
yes, that and the fact that pretty much every other option is irrelevant at that point 🤔 I guess we could downgrade it to a warning probably... playing safe for the time being |
I think this would be what I'd expect as a user. One could reduce it to being only emitted, if the name template does not include |
to be fair that error only happens when there's not name template set, so I guess we can use the binary name template if any of the formats is binary and that's it :) |
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
This can only be merged once goreleaser/goreleaser#5455 is released officially.
Pluralize
format
and allow create multiple archives with the same configuration.Also allow to override the formats for a GOOS.
Closes #5436
TODO:
format