Skip to content

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Jan 15, 2025

Pluralize format and allow create multiple archives with the same configuration.

Also allow to override the formats for a GOOS.

Closes #5436

TODO:

  • improve docs
  • check examples and etc still using singular format

Pluralize `format` and allow create multiple archives with the same
configuration.

Also allow to override the formats for a GOOS.

Closes #5436
@caarlos0 caarlos0 added the enhancement New feature or request label Jan 15, 2025
@caarlos0 caarlos0 self-assigned this Jan 15, 2025
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 15, 2025
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Copy link

cloudflare-workers-and-pages bot commented Jan 16, 2025

Deploying goreleaser with  Cloudflare Pages  Cloudflare Pages

Latest commit: e7bf67f
Status: ✅  Deploy successful!
Preview URL: https://c6bb4fef.goreleaser.pages.dev
Branch Preview URL: https://archive-formats.goreleaser.pages.dev

View logs

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.78%. Comparing base (5fb6204) to head (e7bf67f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5455      +/-   ##
==========================================
- Coverage   82.86%   82.78%   -0.09%     
==========================================
  Files         157      157              
  Lines       15368    15381      +13     
==========================================
- Hits        12735    12733       -2     
- Misses       2081     2091      +10     
- Partials      552      557       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@klaernie
Copy link

Awesome, didn't expect this to materialize so quickly!

I just gave it a try, and it works nicely and behaves exactly as I'd expect.

klaernie added a commit to editorconfig-checker/editorconfig-checker that referenced this pull request Jan 16, 2025
klaernie added a commit to editorconfig-checker/editorconfig-checker that referenced this pull request Jan 16, 2025
@klaernie
Copy link

Just out of curiosity: why does the binary archive format not mix with the other formats? Is it just the different default naming template?

@caarlos0
Copy link
Member Author

Just out of curiosity: why does the binary archive format not mix with the other formats? Is it just the different default naming template?

yes, that and the fact that pretty much every other option is irrelevant at that point 🤔

I guess we could downgrade it to a warning probably... playing safe for the time being

@klaernie
Copy link

I guess we could downgrade it to a warning probably... playing safe for the time being

I think this would be what I'd expect as a user. One could reduce it to being only emitted, if the name template does not include {{.Binary}} - since the user then has definitely considered this problem and solved it in the template.

@caarlos0
Copy link
Member Author

to be fair that error only happens when there's not name template set, so I guess we can use the binary name template if any of the formats is binary and that's it :)

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 merged commit 6487947 into main Jan 19, 2025
17 of 19 checks passed
@caarlos0 caarlos0 deleted the archive-formats branch January 19, 2025 20:35
klaernie added a commit to editorconfig-checker/editorconfig-checker that referenced this pull request Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add archive format instead of overriding it
2 participants