feat(gitea): implement Changelog function
#4794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `strings` package import to `gitea.go` - Implement `Changelog` function in `gitea.go` - Update `useGitea` constant in `changelog.go` - Add test for `useGitea` in `changelog_test.go` - Update `changelog.md` with information about `gitea` customization Signed-off-by: appleboy <appleboy.tw@gmail.com>
Changelog functionChangelog function
|
Hi @caarlos0 Please help to review. |
caarlos0
reviewed
Apr 22, 2024
Comment on lines
+90
to
+91
| commit.Author.UserName, | ||
| commit.RepoCommit.Author.Email, |
There was a problem hiding this comment.
would it be better to use only the author username?
seems like putting the email would polute the changelogs quite a bit
|
thanks for the pr, and sorry for the late review, I was afk this weekend |
Co-authored-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stringspackage import togitea.goChangelogfunction ingitea.gouseGiteaconstant inchangelog.gouseGiteainchangelog_test.gochangelog.mdwith information aboutgiteacustomizationref: