wip: checksums #4641
Closed
wip: checksums #4641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Deploying with
|
| Latest commit: |
68e0d11
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://77d14efb.goreleaser.pages.dev |
| Branch Preview URL: | https://checksums.goreleaser.pages.dev |
|
refs #1805 |
|
not really liking this implementation either 🤔 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fundamentally changes the way checksums work.
Historically, we would checksum everything when the pipe ran.
Later on, we added the ability to refresh the checksum at any given time, which worked fine for cases in which a file could be modified after it was first checksummed.
In #4618, @F21 requested an interesting (and IMHO valid) new feature: one checksum file per artifact, instead of a single
checksums.txt.That feature was simply not possible to implement with the old implementation of checksums.
This PR does a couple of things:
artifacts.Checksumartifacts.Checksummerinterfaceartifacts.ChecksummingArtifacts, with a newListmethod that will in fact eval the checksums every time it's calledpipe/checksum.Runnow sets the checksummer impl intoctx.Artifactsartifacts.ChecksumI'm not sure yet if this is the best approach, but after some tries with different ideas, this is def the best one I got so far.
Happy to hear any feedback you might have 🙏
closes #4618