fix: archive ids #3052
Merged
fix: archive ids #3052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #3052 +/- ##
==========================================
- Coverage 84.51% 84.50% -0.01%
==========================================
Files 112 112
Lines 9190 9185 -5
==========================================
- Hits 7767 7762 -5
Misses 1149 1149
Partials 274 274
Continue to review full report at Codecov.
|
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently it does not handle universal binaries very well if there are ids different than the
defaultThis makes the default ids filter empty, so it actually should archive all, not just the ids from the builds section.