Codecov Report

Merging #2838 (01eaf47) into main (2c6b51c) will decrease coverage by 0.13%.
The diff coverage is 81.55%.

@@            Coverage Diff             @@
##             main    #2838      +/-   ##
==========================================
- Coverage   84.55%   84.42%   -0.14%     
==========================================
  Files         110      111       +1     
  Lines        8400     8783     +383     
==========================================
+ Hits         7103     7415     +312     
- Misses       1051     1101      +50     
- Partials      246      267      +21     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c6b51c...01eaf47. Read the comment docs.

Yo, I'm one of the AUR moderators and general Go packager in Arch Linux. I looked over the code and it seems fine. I tried answering the questions at the top of the PR as well. Feel free to ask if you wonder about anything else.

it seems that AUR defaults to master, although I couldn't find any references for that... is that assumption correct?

Yes, and this won't change as the underlying AUR repository is using git namespaces where the branches are hardcoded to master. The docs should probably be updated to reference that.

the auth method is a bit cumbersome, is there a better way?

There isn't. SSH keys is the only way and I'm not aware of any changes being introduced in the Python rewrite.

are the docs clear enough?

I think there needs to be a link to the AUR submission guidelines. Rest of the links are a good guideline.

Hey @Foxboron, many thanks for the review! I think I addressed all your points, feel free to take another look if you can 🙏

I also made a few more improvements:

• enforce -bin suffix on pkgname
• maintainers can be a list
• more tests 🙏

It looks fine on my end. I like the fact you enforce -bin on pkgname. The only thing that might be missing is validpgpkeys, but I'm not sure how often people sign their release artfifacts with goreleaser. Rest looks good to me :)