Skip to content

Conversation

caarlos0
Copy link
Member

refs #2574
closes #2833

Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 14, 2022
@caarlos0 caarlos0 changed the title Build fix: template main with gomod.proxy Jan 14, 2022
@caarlos0 caarlos0 added the bug Something isn't working label Jan 14, 2022
@caarlos0 caarlos0 self-assigned this Jan 14, 2022
@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #2834 (a928ba3) into main (3d2042c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2834   +/-   ##
=======================================
  Coverage   84.60%   84.60%           
=======================================
  Files         108      109    +1     
  Lines        8380     8381    +1     
=======================================
+ Hits         7090     7091    +1     
  Misses       1045     1045           
  Partials      245      245           
Impacted Files Coverage Δ
internal/builders/golang/build.go 92.22% <ø> (-0.50%) ⬇️
internal/pipe/gomod/gomod_proxy.go 73.40% <ø> (ø)
internal/pipe/prebuild/prebuild.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d2042c...a928ba3. Read the comment docs.

@caarlos0 caarlos0 merged commit a6a6e11 into main Jan 14, 2022
@caarlos0 caarlos0 deleted the build branch January 14, 2022 13:33
@github-actions github-actions bot added this to the v1.4.0 milestone Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gomod proxy fails when build main is templated
1 participant