Skip to content

Conversation

progrhyme
Copy link

...to fetch tags info to generate changelog correctly from previous tag


Recently, I started to use GoReleaser to release a Golang project on GitHub.

With the sample setting shown on this page, I found all commit history appear on my release notes.
It should be only commits from previous release.

I found this is because the tags info were missing even after the "Unshallow" step.
I added options --tags --force, then I get right changelog including commits from previous release like this:

Executed workflow job for above is this: https://github.com/progrhyme/shelp/actions/runs/135036661

Thanks,

to fetch tags info to generate changelog correctly from previous tag
@vercel
Copy link

vercel bot commented Jun 14, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click on the icon next to each commit.

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 14, 2020
@codecov
Copy link

codecov bot commented Jun 14, 2020

Codecov Report

Merging #1608 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1608   +/-   ##
=======================================
  Coverage   85.31%   85.31%           
=======================================
  Files          70       70           
  Lines        3887     3887           
=======================================
  Hits         3316     3316           
  Misses        467      467           
  Partials      104      104           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f739c81...bfa4c2d. Read the comment docs.

@caarlos0
Copy link
Member

Something that changed recently on the checkout action:

https://github.com/actions/checkout#fetch-all-history-for-all-tags-and-branches

I think we can use that instead...

cc/ @crazy-max

@crazy-max
Copy link
Member

@caarlos0 Yes indeed we should use fetch-depth: 0 and remove the unshallow step.

crazy-max added a commit to goreleaser/goreleaser-action that referenced this pull request Jun 15, 2020
@caarlos0 caarlos0 mentioned this pull request Jun 15, 2020
@progrhyme progrhyme deleted the patch-1 branch June 16, 2020 15:33
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants