feat: retry downloading releases json #503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds retry logic to improve reliability when downloading GoReleaser releases JSON data from remote endpoints. The change addresses potential network issues that could cause transient failures when fetching release information.
- Introduces a generic retry mechanism with configurable retries and timeout
- Wraps HTTP requests to the GoReleaser releases endpoint with retry logic
- Refactors existing HTTP client usage to utilize the new retry functionality
Comments suppressed due to low confidence (1)
src/github.ts:115
- Creating a new HttpClient instance on each retry attempt is inefficient. Consider creating the HttpClient once outside the retry function or reusing the same instance.
const http: httpm.HttpClient = new httpm.HttpClient('goreleaser-action');
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs https://github.com/orgs/goreleaser/discussions/5954