fix: do not get releases.json if version is specific #502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the GitHub release resolution process by skipping the expensive JSON fetch operation when a specific version (not a version range) is requested. Instead of always checking the releases JSON file, it validates if the version is a specific semantic version and directly constructs the tag name.
Key changes:
- Added early return path for specific semantic versions to avoid unnecessary network calls
- Preserved existing logic for handling GoReleaser Pro suffix for versions < 2.7.0
- Added comprehensive test coverage for the new optimization path
Reviewed Changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/github.ts | Implements early return optimization for specific versions in getReleaseTag function |
| tests/github.test.ts | Adds test cases to verify the optimization works for versions with and without 'v' prefix |
utkuozdemir
approved these changes
Aug 2, 2025
crazy-max
approved these changes
Aug 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #489