Skip to content

Ambiguity in setting FileClosedEvent in filter #1046

New issue
New issue
Closed
#1059
Closed
Ambiguity in setting FileClosedEvent in filter#1046
#1059
Labels
Good first issueHelp welcome :)inotify
@xieyuguang

Description

@xieyuguang
xieyuguang
opened on Jul 18, 2024

If the filter is set to FileClosedEvent, the mask is set to InotifyConstants.IN_CLOSE which includes IN_CLOSE_WRITE and IN_CLOSE_NOWRITE, but only IN_CLOSE_WRITE will call on_closed(). I think line 236 should be modified to event_mask |= InotifyConstants.IN_CLOSE_WRITE to improve performance and maintain logical consistency in the code.

watchdog/src/watchdog/observers/inotify.py

Lines 235 to 236 in 9f23b59

elif cls is FileClosedEvent:
event_mask |= InotifyConstants.IN_CLOSE

watchdog/src/watchdog/observers/inotify.py

Lines 190 to 199 in 9f23b59

elif event.is_close_write and not event.is_directory:
cls = FileClosedEvent
self.queue_event(cls(src_path))
self.queue_event(DirModifiedEvent(os.path.dirname(src_path)))
elif event.is_open and not event.is_directory:
cls = FileOpenedEvent
self.queue_event(cls(src_path))
# elif event.is_close_nowrite and not event.is_directory:
# cls = FileClosedEvent
# self.queue_event(cls(src_path))

Metadata

Metadata

Assignees

No one assigned

    Labels

    Good first issueHelp welcome :)inotify

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions