refactor(cmd/goproxy): simplify binary version handling #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release-as: 0.21.0 Signed-off-by: Aofei Sheng <aofei@aofeisheng.com>
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the binary version handling to simplify version injection and improve consistency by renaming the version variable and function.
- Renames the global version variable to VersionOverride and the version retrieval function to Version.
- Updates build commands in Dockerfile and test workflow to remove explicit ldflags injection for version information.
- Adjusts the .goreleaser.yaml configuration to use VersionOverride for version injection in releases.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| cmd/goproxy/internal/internal.go | Renames Version variable to VersionOverride and updates version retrieval logic. |
| cmd/goproxy/internal/goproxy_cmd.go | Replaces call to binaryVersion() with Version() to use the updated version logic. |
| Dockerfile | Simplifies the go build command by removing explicit ldflags settings for version injection. |
| .goreleaser.yaml | Updates ldflags to use VersionOverride for release builds. |
| .github/workflows/test.yaml | Adjusts the build command to match the new approach by removing version ldflags. |
Comments suppressed due to low confidence (2)
Dockerfile:17
- The updated Dockerfile build command no longer injects version information via ldflags. Please verify that this omission is intentional given that .goreleaser.yaml still sets the version via VersionOverride.
CGO_ENABLED=0 go build -trimpath -ldflags "-s -w" -o bin/ ./cmd/goproxy;
.github/workflows/test.yaml:51
- The build command in the test workflow no longer sets ldflags for version injection. Confirm that test builds are expected to lack version details to maintain consistency with other build configurations.
run: go build -v -trimpath -ldflags "-s -w" -o bin/ ./cmd/goproxy
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #129 +/- ##
==========================================
+ Coverage 80.67% 81.20% +0.53%
==========================================
Files 11 11
Lines 1371 1362 -9
==========================================
Hits 1106 1106
+ Misses 257 248 -9
Partials 8 8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release-as: 0.21.0