test: improve test organization with subtests #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #110 +/- ##
=======================================
Coverage 80.87% 80.87%
=======================================
Files 11 11
Lines 1370 1370
=======================================
Hits 1108 1108
Misses 255 255
Partials 7 7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
PR Overview
This PR reorganizes the tests to use subtests (via t.Run) for improved clarity and isolation, while also adjusting error reporting from fatal assertions to non‐fatal ones in several test cases. Key changes include:
- Wrapping individual test cases in t.Run with subtest names.
- Changing several call sites from t.Fatal/t.Fatalf to t.Error/t.Errorf.
- Minor adjustments in error message formatting across multiple test files.
Reviewed Changes
| File | Description |
|---|---|
| goproxy_test.go | Refactored tests to use subtests and modified error reporting. |
| cacher_test.go | Introduced subtests and adjusted error handling in caching tests. |
| http_test.go | Updated subtests and structured error expectations in HTTP tests. |
| sumdb_client_ops_test.go | Switched to subtests and lambda-based configurations for clarity. |
| response_test.go | Wrapped response tests in subtests with simplified error messages. |
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
goproxy_test.go:182
- [nitpick] Using numeric identifiers as subtest names may not be sufficiently descriptive for test reports. Consider providing more meaningful subtest names to improve clarity.
t.Run(strconv.Itoa(tt.n), func(t *testing.T) {
Signed-off-by: Aofei Sheng <aofei@aofeisheng.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.