chore(.goreleaser.yaml): add DOCKER_IMAGE_REPO for dynamic repo config #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aofei Sheng <aofei@aofeisheng.com>
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
.goreleaser.yaml:4
- The default value for DOCKER_IMAGE_REPO is set to 'goproxy', which may not be a valid or complete Docker image repository (typically including a registry domain). Consider updating this default (or adding comments) to ensure clarity on the expected full repository name.
- DOCKER_IMAGE_REPO={{envOrDefault "DOCKER_IMAGE_REPO" "goproxy"}}
.github/workflows/release.yaml:46
- There is an inconsistency between the default value in .goreleaser.yaml ('goproxy') and the overridden value in release.yaml ('ghcr.io/${{github.repository}}'). Consider aligning these values or documenting the intended behavior to avoid misconfiguration.
+ DOCKER_IMAGE_REPO: ghcr.io/${{github.repository}}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #104 +/- ##
=======================================
Coverage 81.61% 81.61%
=======================================
Files 11 11
Lines 1360 1360
=======================================
Hits 1110 1110
Misses 243 243
Partials 7 7 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.