feat: implement Token-based test authentication #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xushiwei
reviewed
Jan 30, 2024
| } | ||
|
|
||
| func (rt *JwtRoundTripper) RoundTrip(req *http.Request) (*http.Response, error) { | ||
| req.Header.Set("Authorization", rt.Token) |
There was a problem hiding this comment.
according implementation, there is nothing about jwt.
so please change to another class name.
There was a problem hiding this comment.
Thanks for your comments. JwtAuth is already renamed to tokenAuth.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #36 +/- ##
===========================================
- Coverage 100.00% 96.82% -3.18%
===========================================
Files 1 3 +2
Lines 51 63 +12
===========================================
+ Hits 51 61 +10
- Misses 0 2 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the JWT feature for example. I'm not sure whether it will work since I'm not clear how the test cases will realize their authentication. If this code is a feasible implementation, I'll add other authentication functions later. Please give me some advice, thx.
mod: since this auth feature is not only feasible to JWT, rename it to token authentication.