AppV2: ensure isolation of handler state per request #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented a new duplication mechanism for the handler to create separate instances per request. This change addresses an issue where the same handler instance was shared across multiple requests, leading to state leakage and inconsistencies in AppV2. Each request now uses a fresh handler instance, ensuring isolated and consistent state management. Updates goplus/builder#532 Signed-off-by: Aofei Sheng <aofei@aofeisheng.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #116 +/- ##
=======================================
Coverage 90.38% 90.38%
=======================================
Files 10 10
Lines 104 104
=======================================
Hits 94 94
Misses 10 10 ☔ View full report in Codecov by Sentry. |
|
Provide builtin clone mechanism to replace reflection: #117 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a new duplication mechanism for the handler to create separate instances per request. This change addresses an issue where the same handler instance was shared across multiple requests, leading to state leakage and inconsistencies in AppV2.
Each request now uses a fresh handler instance, ensuring isolated and consistent state management.
Updates goplus/builder#532