Skip to content

Conversation

glennzw
Copy link
Collaborator

@glennzw glennzw commented Apr 11, 2020

Scenario:

As an admin you can create user accounts, but if those users change their passwords you're unable to authenticate to their accounts (e.g. for debugging / other assistance). The only current solution would be for the user to share their password, or for you as the admin to change their password.

Solution:

This pull request adds a new button in the User Management section that allows admin users to immediately 'su' to that user account.

Screenshot 2020-04-11 at 16 08 17

Copy link
Collaborator

@jordan-wright jordan-wright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @glennzw!

Thanks for sending this in. I could see this being useful, and this approach seems fine. Perhaps in the future, we could offer a way to get back out of the impersonation without having to logout/login. But that's a future problem to solve 😄

I made a few notes in the PR. If you could take a look, I'd appreciate it! Thanks again for taking the time to knock this out!

@glennzw
Copy link
Collaborator Author

glennzw commented Apr 12, 2020

Hey @glennzw!

Thanks for sending this in. I could see this being useful, and this approach seems fine. Perhaps in the future, we could offer a way to get back out of the impersonation without having to logout/login. But that's a future problem to solve 😄

Yeah I started off on a more complex idea of generating one-time login links that are stored in the DB and when clicked log in as the predetermined user and then expire - but it started getting complicated so I went with this easier solution for now 😄

@jordan-wright jordan-wright merged commit 38a6a77 into gophish:master Apr 27, 2020
@jordan-wright
Copy link
Collaborator

LGTM- thanks @glennzw!

jordan-wright added a commit that referenced this pull request May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants