Skipping crypto tests with expired certificate #1360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flimzy
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Master started failing CI because
TestVerifyConnectionandTestResumptionKeepsOCSPAndSCTfailed with "bad certificate". Digging into the problem revealed thattestRSACertificateIssuer, a hardcoded byte array of a certificate, expired in 2025-01-01. The last update to those that certificate for go1.19.13 is in 2019-06-20, so they gave it 6 years before expiring.Solution
Added overrides to skip those tests with a comment to check in future versions.
It appears that the same string in go1.23.1 but have added code to those tests to update the time stamp on the certificates, so as we hit go1.20 and beyond we should check if we can stop skipping these tests or not.