Skip to content

delete minor unreachable code caused by t.Fatal #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2022
Merged

delete minor unreachable code caused by t.Fatal #36

merged 1 commit into from
Nov 3, 2022

Conversation

Abirdcfly
Copy link
Contributor

Signed-off-by: Abirdcfly fp544037857@gmail.com

see https://go.dev/play/p/w4Xuilq-KvA for example:

package main

import (
	"testing"
)

func TestLastIndex(t *testing.T) {
	t.Fatalf("this line will print and exit")
	t.Errorf("this line can't print")
}

/* output:
=== RUN   TestLastIndex
    prog.go:8: this line will print and exit
--- FAIL: TestLastIndex (0.00s)
FAIL

Program exited.
*/

@Abirdcfly
delete minor unreachable code caused by t.Fatal
872a394 
Signed-off-by: Abirdcfly <fp544037857@gmail.com>
@hyper0x hyper0x merged commit 7675244 into gopcp:master Nov 3, 2022
@Abirdcfly Abirdcfly deleted the patch-1 branch November 3, 2022 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Abirdcfly @hyper0x