Prevent panic on context cancellation #785
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using the opcua server in tests, with a short-lived context. I sometimes get a panic, because
msg
is nil.This PR prevents this.
The diff may look large when whitespaces are not ignored, because I removed an indentation (
ctx.Err()
is more concise thanselect{<-ctx.Done;default}
and more "left-aligned"). diff ignoring whitespacesBTW: thanks for this huge package!!