Skip to content

client: use nil-checked secure channel #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 27, 2025
Merged

client: use nil-checked secure channel #775

merged 2 commits into from
Feb 27, 2025

Conversation

magiconair
Copy link
Member

@magiconair magiconair commented Feb 27, 2025 •
edited
Loading

this is a regression introduced in commit 4d56b5d. The race condition was fixed in 5a15559.

Fixes #774

@magiconair magiconair added this to the v0.7.1 milestone Feb 27, 2025
@magiconair
bump go to 1.23/1.24
8f6df6d
@magiconair
client: use nil-checked secure channel
c58424a 
This fixes a regression from commit 4d56b5d
which reverts the fix for the race condition
added in 5a15559

Fixes #774
@magiconair magiconair force-pushed the issue-774-read-failed branch from 60712df to c58424a Compare February 27, 2025 14:25
@magiconair magiconair merged commit 578c8e5 into main Feb 27, 2025
5 checks passed
@magiconair magiconair deleted the issue-774-read-failed branch February 27, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.7.1
Development

Successfully merging this pull request may close these issues.

Read panicked with nil pointer dereference
1 participant
@magiconair