add DialTimeout and cleanup ResolveEndpoint #372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kung-foo
commented
Aug 26, 2020
- cleanup and rebase of 🚧 Add dial timeout and cleanup ResolveEndpoint #278.
- implemented suggestion from @dwhutchison in 🚧 Add dial timeout and cleanup ResolveEndpoint #278 (comment)
magiconair
reviewed
Aug 27, 2020
|
Still want to clean this one up @kung-foo ? |
|
yeah, let me take a crack at resolving the conflicts and cleaning up. |
magiconair
requested changes
Apr 23, 2025
|
and yes, i'm fine with 0.8 due to the api change |
|
well, that only took 5 years... |
|
Better late than never 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.