server CreateSession does not return endpoint on trailing slash mismatch #783
Description
Hi, I am in the process of setting up a opc ua server using for testing purposes of our .NET application.
Using this code to create the server
var opts []server.Option
opts = append(opts, server.EnableSecurity("None", ua.MessageSecurityModeNone))
opts = append(opts,
server.EnableAuthMode(ua.UserTokenTypeAnonymous),
)
opts = append(opts,
server.EndPoint("localhost", 4840),
)
endpoints := []string{
"localhost",
}
certbytes, keybytes, err := generateCert(endpoints, 4096, time.Minute*60*24*365*10)
if err != nil {
log.Fatalf("problem creating cert: %v", err)
}
var cert []byte
c, err := tls.X509KeyPair(certbytes, keybytes)
if err != nil {
log.Printf("Failed to load certificate: %s", err)
} else {
pk, ok := c.PrivateKey.(*rsa.PrivateKey)
if !ok {
log.Fatalf("Invalid private key")
}
cert = c.Certificate[0]
opts = append(opts, server.PrivateKey(pk), server.Certificate(cert))
}
logger := Logger(1)
opts = append(opts,
server.SetLogger(logger),
)
s := server.New(opts...)
return sI am unable to create a session using our .NET client, as supposedly the endpoints do not match.
I have narrowed it down to the following code block in session_service.go
matching_endpoints := make([]*ua.EndpointDescription, 0)
for i := range s.srv.endpoints {
ep := s.srv.endpoints[i]
if ep.EndpointURL == req.EndpointURL {
matching_endpoints = append(matching_endpoints, ep)
}
}
response := &ua.CreateSessionResponse{
ResponseHeader: responseHeader(req.RequestHeader.RequestHandle, ua.StatusOK),
SessionID: sess.ID,
AuthenticationToken: sess.AuthTokenID,
RevisedSessionTimeout: float64(sess.cfg.sessionTimeout / time.Millisecond),
MaxRequestMessageSize: 0, // Not used
ServerSignature: &ua.SignatureData{
Signature: sig,
Algorithm: alg,
},
ServerCertificate: s.srv.cfg.certificate,
ServerNonce: nonce,
ServerEndpoints: matching_endpoints,
}The problem seems to be, that req.EndpointURL has a trailing slash i.e. opc.tcp://localhost:4840/ (automatically appended by the .NET library) while the servers endpoint does not. (listing s.Endpoints() gives me opc.tcp://localhost:4840)
So no endpoints are returned in the response.
Is this not matching a conscious decision / does the trailing slash matter? (I am no expert in working with opc and its endpoint-handling) or can I somehow configure the endpoint with a trailing slash?
Thanks!