Skip to content

Very dangerous log.Fatal called in several places #762

@paologaleotti

Description

@paologaleotti

(using v6.0.2)
We are about to use this in production and we noticed that when passing an invalid certificate it panics. This can cause unexpected failures at runtimes, and i saw that #616 was marked as closed but it does not seem to be.

There are three log.Fatal in the codebase:

  • config.go line 325: "Failed to parse certificate"
  • server.go line 112 and line 151

I wonder why the error cannot bubble up to the NewClient because that now returns an error.

Are we missing something? Thanks in advance

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions