Fix issue with config values missing from app context #833
Conversation
Codecov Report
@@ Coverage Diff @@
## master #833 +/- ##
==========================================
+ Coverage 64.3% 64.33% +0.04%
==========================================
Files 170 170
Lines 9621 9631 +10
==========================================
+ Hits 6186 6196 +10
Misses 2675 2675
Partials 760 760
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Thanks a lot for your PR, unfortunately this will break the config handling. Usually the appropriate config options should be set for a sub store by calling config.WithContext which will only override config options not already set. If you now set the root store options here it will always overwrite any sub-store specific config options.
|
I'm curious what this breaks since the config itself will already be set or have the default values at this point and this only sets values which come from the config. Where would sub-stores be overriding config values? |
|
The WithContext method of a sub store config will only overwrite context values which weren't set before. This would break if you'd populate these with the root store confiy |
|
I guess my confusion is that the first thing done in |
|
For context, I was aiming to solve #838 with this PR (which I admittedly filed after this PR). This seemed like the right fix because the config is currently passed into initContext but never actually used. |
|
Yes ... it's a fair approach, but I don't think this one will work. Let's see if we can find a proper solution in #838 |
When I started experimenting with gopass I was getting frustrated with having a pager open when I didn't want it to, so I tried setting it in a config file. However, it looks like these values were being ignored because they never made it into the app context.
This loads all config values into the app context which have an available helper in ctxutil.