Skip to content

Add recipient editor when confirming recipients #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2018
Merged

Add recipient editor when confirming recipients #703

merged 1 commit into from
Mar 9, 2018

Conversation

dominikschulz
Copy link
Member

Fixes #498

@dominikschulz dominikschulz added ux User experience / User Interface related crypto Crypto Backends labels Mar 9, 2018
@codecov
Copy link

codecov bot commented Mar 9, 2018

Codecov Report

Merging #703 into master will increase coverage by 1.26%.
The diff coverage is 58.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #703      +/-   ##
==========================================
+ Coverage   64.39%   65.66%   +1.26%     
==========================================
  Files         150      150              
  Lines        8459     8549      +90     
==========================================
+ Hits         5447     5613     +166     
+ Misses       2348     2269      -79     
- Partials      664      667       +3
Impacted Files Coverage Δ
commands.go 92.12% <ø> (ø) ⬆️
backend/crypto/gpg/cli/utils.go 100% <ø> (+6.67%) ⬆️
config/context.go 100% <100%> (ø) ⬆️
backend/crypto/gpg/cli/binary.go 82.61% <100%> (+1.66%) ⬆️
store/sub/write.go 35.29% <100%> (+1.29%) ⬆️
action/edit_linux.go 100% <100%> (ø) ⬆️
utils/ctxutil/ctxutil.go 100% <100%> (ø) ⬆️
action/clihelper.go 52.87% <41.67%> (-11.34%) ⬇️
store/sub/recipients.go 58.74% <77.78%> (+3.52%) ⬆️
config/store_config.go 76.12% <83.33%> (-0.07%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 213e805...3b0178d. Read the comment docs.

@dominikschulz dominikschulz merged commit 9c89249 into gopasspw:master Mar 9, 2018
@dominikschulz dominikschulz deleted the feature/issue-498 branch March 9, 2018 09:53
@AnomalRoil AnomalRoil mentioned this pull request Mar 9, 2018
Merged
@stefan2904 stefan2904 mentioned this pull request Apr 24, 2019
Closed
kpitt pushed a commit to kpitt/gopass that referenced this pull request Jul 21, 2022
@dominikschulz
Add recipient editor when confirming recipients (gopasspw#703)
925e112 
Fixes gopasspw#498
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
crypto Crypto Backends ux User experience / User Interface related
Projects
None yet
Milestone
1.7.0 - Experimental Crypto
Development

Successfully merging this pull request may close these issues.
1 participant
@dominikschulz