Skip to content

[feat] Remove expensive and unmaintained zxcvbn-go strength checker #3133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 20, 2025
Merged

[feat] Remove expensive and unmaintained zxcvbn-go strength checker #3133

merged 1 commit into from
Apr 20, 2025

Conversation

twpayne
Copy link
Contributor

@twpayne twpayne commented Apr 20, 2025 •
edited
Loading

Fixes #3132.

Improves start-up time by 533%.

Before:

$ time ./gopass --version
gopass 1.15.15-git+HEAD (a27a9cc1) go1.24.2 linux amd64
./gopass --version  0.03s user 0.01s system 130% cpu 0.032 total

After:

$ time ./gopass --version
gopass 1.15.15-git+HEAD (3ebb1a7b) go1.24.2 linux amd64
./gopass --version  0.00s user 0.00s system 112% cpu 0.006 total

@twpayne
[feat] Remove expensive and unmaintained zxcvbn-go strength checker
c326009 
Signed-off-by: Tom Payne <twpayne@gmail.com>
@dominikschulz
Copy link
Member

Very nice cleanup & improvement. Thanks. Let me just try to reproduce the issue, then we can merge this.

@dominikschulz dominikschulz self-requested a review April 20, 2025 18:17
@dominikschulz dominikschulz added the cleanup Code hygiene label Apr 20, 2025
@dominikschulz dominikschulz merged commit 7e3c54d into gopasspw:master Apr 20, 2025
9 checks passed
@twpayne twpayne deleted the remove-zxcvbn-go branch April 20, 2025 18:50
This was referenced Apr 20, 2025
Closed
Merged
sudoforge pushed a commit to sudoforge/gopass that referenced this pull request May 20, 2025
@twpayne @sudoforge
[feat] Remove expensive and unmaintained zxcvbn-go strength checker (g…
4453630 
…opasspw#3133)

Signed-off-by: Tom Payne <twpayne@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikschulz dominikschulz dominikschulz approved these changes

Assignees
No one assigned
Labels
cleanup Code hygiene
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Performance: Use of github.com/nbutton23/zxcvbn-go adds ~25ms of latency to every run
2 participants
@twpayne @dominikschulz