[chore] Do not run linters twice #3119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already have a golangci-lint GHA but we still run it in the linux tests. This often creates inconsistent findings. Let's not do that and only run the linter once in it's own action. Also rename the test targets that were created for Travis CI a long time ago. Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
GLobyNew
pushed a commit
to GLobyNew/gopass
that referenced
this pull request
Apr 17, 2025
We already have a golangci-lint GHA but we still run it in the linux tests. This often creates inconsistent findings. Let's not do that and only run the linter once in it's own action. Also rename the test targets that were created for Travis CI a long time ago. Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
sudoforge
pushed a commit
to sudoforge/gopass
that referenced
this pull request
May 20, 2025
We already have a golangci-lint GHA but we still run it in the linux tests. This often creates inconsistent findings. Let's not do that and only run the linter once in it's own action. Also rename the test targets that were created for Travis CI a long time ago. Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have a golangci-lint GHA but we still run it in the linux tests. This often creates inconsistent findings. Let's not do that and only run the linter once in it's own action. Also rename the test targets that were created for Travis CI a long time ago.