[ENHANCEMENT] Make it possible to override show.autoclip
#3082
Conversation
With this change is now possible to use `--alsoclip=false` on the command line to override the `show.autoclip` set in the config file. Signed-off-by: Fabio Alessandro Locati <me@fale.io>
There was a problem hiding this comment.
Hello @Fale, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request enhances the show command to allow overriding the show.autoclip configuration option from the command line. Specifically, it introduces the --alsoclip flag to control whether the password should be automatically copied to the clipboard, regardless of the show.autoclip setting in the config file. This provides more flexibility for users who want to temporarily disable or enable autoclipping without modifying their global configuration.
Highlights
- Enhancement: Adds the
--alsoclipflag to override theshow.autoclipconfig setting. - Configuration Override: Allows users to control autoclipping behavior from the command line.
Changelog
- internal/action/show.go
- Introduces logic to prioritize the
--alsoclipflag over theshow.autoclipconfig setting (lines 54-55). - Modifies the condition for copying the password to the clipboard to use
IsAlsoClip(ctx)instead of directly checkingconfig.Bool(ctx, "show.autoclip")(line 219). - Removes redundant check for
config.Bool(ctx, "show.autoclip")inshowGetContentfunction (line 277).
- Introduces logic to prioritize the
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Did you know?
The first implementation of copy and paste was in 1973 by Larry Tesler while working at Xerox PARC. He later joined Apple and popularized the feature.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request enhances the show command by allowing users to override the show.autoclip configuration option via the --alsoclip command-line flag. This provides more flexibility in controlling whether the secret is automatically copied to the clipboard. The changes seem reasonable and address the intended functionality.
Merge Readiness
The changes in this pull request seem to address the intended functionality and provide a useful enhancement. I did not find any critical or high severity issues. I am unable to directly approve the pull request, and recommend that others review and approve this code before merging.
Signed-off-by: Fabio Alessandro Locati <me@fale.io>
|
Test failed for the (uncorrelated) gpg error. Am I unlucky or this is becoming more frequent? |
Signed-off-by: Fabio Alessandro Locati <me@fale.io>
With this change is now possible to use
--alsoclip=falseon the command line to override theshow.autoclipset in the config file.