[chore] Add tpl func tests and fix two small issues #3058
Conversation
Timestamps were not rounded correctly and the truncate function was not trunacting correctly. Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
There was a problem hiding this comment.
Hello @dominikschulz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request addresses two small issues in the template functions: incorrect rounding of timestamps and incorrect truncation of strings. It also adds tests for the template functions to ensure their correctness.
Highlights
- Bug fix: The
roundDurationfunction was not rounding timestamps correctly. This has been fixed by changing>to>=in the comparison. - Bug fix: The
truncatefunction was not truncating strings correctly. This has been fixed by removing-3from the length check. - Tests: Added tests for the template functions to ensure their correctness.
Changelog
- internal/tpl/funcs.go
- Fixed incorrect rounding of timestamps in the
roundDurationfunction by changing>to>=in the comparison. - Fixed incorrect truncation of strings in the
truncatefunction by removing-3from the length check.
- Fixed incorrect rounding of timestamps in the
- internal/tpl/funcs_test.go
- Added tests for
md5sum,sha1sum,sha256sum,sha512sum,blake3sum,md5cryptFunc,sshaFunc,ssha256Func,ssha512Func,argon2iFunc,argon2idFunc,bcryptFunc,roundDuration,date,truncate, andjoinfunctions.
- Added tests for
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Did you know?
The text/template package in Go uses a syntax inspired by the popular templating language Mustache.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request addresses two small issues: incorrect timestamp rounding and incorrect truncation function behavior. Additionally, it introduces new tests for template functions. The changes seem reasonable and the added tests are a good practice.
Summary of Findings
Merge Readiness
The pull request appears to be in good shape for merging. The identified issues have been addressed, and the addition of tests enhances the overall quality and reliability of the code. I am unable to directly approve the pull request, and recommend that others review and approve this code before merging.
Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
Co-authored-by: AnomalRoil <AnomalRoil@users.noreply.github.com> Signed-off-by: Dominik Schulz <dominik.schulz@gmail.com>
Timestamps were not rounded correctly and the truncate function was not trunacting correctly.