[BUGFIX] Fixed password not saving to clipboard with safecontent and autoclip true #3053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontent are both enabled Fixed an issue where enabling both AutoClip and SafeContent prevented passwords from being saved to the clipboard. Added tests to cover this case. Signed-off-by: alex <wallneralex7789@gmail.com>
|
fixes #3034 |
AnomalRoil
previously approved these changes
Feb 24, 2025
internal/action/show.go
Outdated
Comment on lines
274
to
278
| if config.Bool(ctx, "show.safecontent") && !ctxutil.IsForce(ctx) && ctxutil.IsShowParsing(ctx) { | ||
| body := showSafeContent(sec) | ||
| if IsAlsoClip(ctx) { | ||
| if IsAlsoClip(ctx) || config.Bool(ctx, "show.autoclip"){ | ||
| return pw, body, nil | ||
| } |
There was a problem hiding this comment.
I'm guessing this won't display the warning "⚠ show.safecontent=true. Use -f to display password, if any" and instead will just display "✔ Copied to clipboard. Will clear in 45 seconds.", right?
But I guess that should be fine, wdyt?
There was a problem hiding this comment.
yes exactly!
just shows the ✔ Copied line
I think it might be a little more intuitive
gofmt -> should now pass golangci-lint Signed-off-by: alex <wallneralex7789@gmail.com>
dominikschulz
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue where enabling both AutoClip and SafeContent prevented passwords from being saved to the clipboard. Added tests to cover this case.
Signed-off-by: Alex Wallner wallneralex7789@gmail.cpm