Skip to content

[feature] Allow setting autosync.interval in minutes with "m" suffix #2731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2023
Merged

[feature] Allow setting autosync.interval in minutes with "m" suffix #2731

merged 1 commit into from
Dec 1, 2023

Conversation

quite
Copy link
Contributor

@quite quite commented Nov 28, 2023

Solves #2730

@quite quite force-pushed the autosync-minutes branch 2 times, most recently from 79a1a02 to d254c6d Compare November 28, 2023 06:20
@quite
Copy link
Contributor Author

quite commented Nov 28, 2023 •
edited
Loading

@dominikschulz what do you think? This does not work entirely, because the returning upon failed parsing does not actually cause the program to exit! Edit: looks like the call to autoSync() doesn't actually care about the returned error: https://github.com/gopasspw/gopass/blob/master/internal/action/init.go#L44

@quite quite marked this pull request as draft November 28, 2023 06:21
@quite quite force-pushed the autosync-minutes branch 3 times, most recently from 3a0e569 to cb99331 Compare November 28, 2023 06:24
@quite quite changed the title WIP: Allow setting autosync.interval in minutes with "m" suffix [feature] Allow setting autosync.interval in minutes with "m" suffix Nov 28, 2023
@quite quite force-pushed the autosync-minutes branch 2 times, most recently from de8e9ce to 673c506 Compare November 28, 2023 07:38
dominikschulz
dominikschulz requested changes Nov 28, 2023
View reviewed changes
quite
quite commented Nov 28, 2023
View reviewed changes
quite
quite commented Nov 28, 2023
View reviewed changes
@quite
[feature] Allow setting autosync.interval in different time units
3d2520a 
Solves gopasspw#2730

Signed-off-by: Daniel Lublin <daniel@lublin.se>
@quite quite marked this pull request as ready for review November 29, 2023 20:58
@quite quite requested a review from dominikschulz November 29, 2023 20:59
dominikschulz
dominikschulz approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@dominikschulz dominikschulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@dominikschulz dominikschulz merged commit bf426e6 into gopasspw:master Dec 1, 2023
@AnomalRoil AnomalRoil mentioned this pull request Dec 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnomalRoil AnomalRoil AnomalRoil left review comments

@dominikschulz dominikschulz dominikschulz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@quite @dominikschulz @AnomalRoil