[bugfix] Fix writes to global config from tests #2727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
767bce5 to
b5adcab
Compare
AnomalRoil
requested changes
Nov 27, 2023
There was a problem hiding this comment.
Seems there are a few issues on Windows
Nit: maybe the gptest.NewUnitTester(t) could return a context too to avoid having to add it to all tests always?
And I guess using ReadOnly configs might bite us when testing the config options, since ReadOnly doesn't allow to change values even in memory, right?
AnomalRoil
reviewed
Nov 27, 2023
There was a problem hiding this comment.
I think now such tests aren't actually testing what we think they are testing:
https://github.com/gopasspw/gopass/pull/2727/files#diff-2bf3cbedfee37a38c52d5f08662f0b4b441ce2a1d1fa915c18e348d167d106cbL67-R72
And we do set config options in a few tests:
internal/action/generate_test.go
41: require.NoError(t, act.cfg.Set("", "generate.autoclip", "false"))
159: require.NoError(t, act.cfg.Set("", "generate.autoclip", ov))
161: require.NoError(t, act.cfg.Set("", "generate.autoclip", "true"))
172: require.NoError(t, act.cfg.Set("", "generate.autoclip", ov))
174: require.NoError(t, act.cfg.Set("", "generate.autoclip", "true"))
internal/action/copy_test.go
30: require.NoError(t, act.cfg.Set("", "generate.autoclip", "false"))
113: require.NoError(t, act.cfg.Set("", "generate.autoclip", "false"))
internal/action/create_test.go
29: require.NoError(t, act.cfg.Set("", "core.notifications", "false"))
30: require.NoError(t, act.cfg.Set("", "core.cliptimeout", "1"))
internal/action/find_test.go
33: require.NoError(t, act.cfg.Set("", "generate.autoclip", "false"))
68: require.NoError(t, act.cfg.Set("", "show.safecontent", "true"))
88: require.NoError(t, act.cfg.Set("", "show.safecontent", "false"))
internal/action/show_test.go
70: require.NoError(t, act.cfg.Set("", "show.safecontent", "true"))
143: require.NoError(t, act.cfg.Set("", "show.safecontent", "false"))
418: require.NoError(t, act.cfg.Set("", "domain-alias.foo.de.insteadOf", "foo.com"))
internal/action/insert_test.go
29: require.NoError(t, act.cfg.Set("", "generate.autoclip", "true"))
87: require.NoError(t, act.cfg.Set("", "show.safecontent", "true"))
116: require.NoError(t, act.cfg.Set("", "show.safecontent", "false"))
139: require.NoError(t, act.cfg.Set("", "generate.autoclip", "false"))
and the fact that moving to a ReadOnly config didn't break any of these tests probably mean they aren't testing useful things?
AnomalRoil
requested changes
Nov 27, 2023
AnomalRoil
reviewed
Nov 27, 2023
Fixes gopasspw#2725 Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
d22c1b6 to
9f402b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2725