Fixing OTP screenshots build issues #2630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using fixed dependency Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
d97fb02 to
fa76acf
Compare
Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
1b427eb to
cc222fd
Compare
dominikschulz
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is sadly the easiest way I've found to fix the builds on all platforms since it seems the upstream dependency has some issues with Solaris and Freebsd.
The other option would be to stick with the original dependency and remove freebsd from the supported platforms.
Let me know if you prefer that.
I've tested this on both Linux and Windows. Would be great if you have a MacOS device handy to test it.