Add gitconfig include support #2574
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feature for gopasspw#2458 RELEASE_NOTES=[FEATURE] Add support for gitconfig include Signed-off-by: Sergei Suslov <sergey.suslov.nsk@gmail.com>
RELEASE_NOTES=n/a Signed-off-by: Sergei Suslov <sergey.suslov.nsk@gmail.com>
| } | ||
| c.path = fn | ||
|
|
||
| loadedConfigs := map[string]struct{}{} |
There was a problem hiding this comment.
You can initialize and add fn directly.
| loadedConfigs := map[string]struct{}{} | ||
| loadedConfigs[fn] = struct{}{} | ||
| configsToLoad := []string{} | ||
| includePaths, includeExists := c.GetAll("include.path") |
There was a problem hiding this comment.
What are you doing here? Maybe add a comment.
| if includeExists { | ||
| configsToLoad = append(configsToLoad, getPathsForNestedConfig(includePaths, c.path)...) | ||
| } | ||
| for len(configsToLoad) > 0 { |
There was a problem hiding this comment.
In Go you'd return early, i.e. if there are no configs to load you should return and otherwise continue. This saves some nesting.
| @@ -264,6 +265,52 @@ func TestLoadConfig(t *testing.T) { | |||
| assert.Equal(t, "false", v) | |||
| } | |||
|
|
|||
| func TestLoadConfigWithInclude(t *testing.T) { | |||
There was a problem hiding this comment.
How do you plan writing to nested configs?
|
Thank you for your contribution. I would love to see this feature merged but in the current state I can't merge it. Due to the lack of recent activity I have to close this PR. Feel free to re-open if you get to address the pending comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature for #2458
RELEASE_NOTES=[FEATURE] Add support for gitconfig include