Make pcapgo EthernetHandle use runtime poller #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows pcapgo to cooperate with the Go runtime poller to not block entire OS thread on operations.
The close-on-exec flag should always be used, where possible. The Go standard library does that everywhere, so it makes sense to use it here, too.
mosajjal
approved these changes
Dec 2, 2024
antoninbas
pushed a commit
to antrea-io/antrea
that referenced
this pull request
Feb 6, 2025
Upgrade to an unreleased version which includes this patch: gopacket/gopacket#99 For #6815 Signed-off-by: Hang Yan <yhang@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows pcapgo to cooperate with the Go runtime poller to not block entire OS thread on operations.
This is rebase of google/gopacket#911