parse TLS client hello packet #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bozhang <bozhang@ebay.com>
|
Does anyone approve running workflows? |
|
hey there. yep I can approve the tests. I got a question around the order of TLS extensions inside the hello packet. does your code cater for that? |
|
What's your question?
Ali Mosajjal ***@***.***> 于2022年9月4日周日 00:24写道：
… hey there. yep I can approve the tests. I got a question around the order
of TLS extensions inside the hello packet. does your code cater for that?
—
Reply to this email directly, view it on GitHub
<#8 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AATRTCPTKDDEPDHUSN6ZJ7LV4PT43ANCNFSM575RFOKA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
张博
|
mosajjal
reviewed
Sep 6, 2022
|
good idea to add this to this PR |
|
@mosajjal it seems that this PR has included the feature that PR provides. |
|
cool. Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.