Changing internal type of CSEQ and Content-Length #61
Conversation
Prior to this int64 have been used to store the values, this requires some, perhaps unsafe "truncation" of contentLength when mapping to the internal buffer for storing payload. I have changed the internal type to better fit the usage of the values, and added guard checks when parsing. To better test for parsing-errors I have refactored testing.
|
@thorsager thanks for this. since we don't use testify in this lib (yet), I commented them out and replaced them with a basic equivalent using stdlib. can you confirm if the tests still work? |
It looks as though the |
|
Sorry for the delay .. I have done a bit of cleanup, adding some helper functions, to allow for more convenience when writing the actual tests |
|
@mosajjal anything I can do to move this one along? |
|
been too busy to take a look at this repo lately. hopefully I'll get some time over the weekend to review the code. |
|
No worries 💪🙂 |
|
good stuff. merged! |
Prior to this int64 have been used to store the values, this requires some, perhaps unsafe "truncation" of contentLength when mapping to the internal buffer for storing payload.
I have changed the internal type to better fit the usage of the values, and added guard checks when parsing.
To better test for parsing-errors I have refactored testing.