OSPFv2: fix DbDesc LSAheader parse #56
Conversation
add missing LSOptions field and fix LSType field offset
|
Hi. thanks for this. please add a test packet that'll fail with |
Added. PTAL |
There was a problem hiding this comment.
RFC 5340's LSA header differs from RFC 2328's LSA header. One has the Options byte, one doesn't. We need a few tests specifically for IPv6 and OSPFv2 if it doesn't exist already.
Yes, it is. However, OSPFv2 and v3 are not compatible within a network configuration, in other words, they do not directly communicate with each other: v2 instances can only communicate with v2, and v3 can only communicate with v3.
Please refer to my explanation above. OSPFv2 with IPv6 are not impossible in a real OSPF configuration. So I don't think there is any necessary to add such test cases. |
This is a bugfix.
Since the origin upstream maintained by google is stall for a long time, I just submit the fix here.
There might be more contributes to OSPFv2 because I am currently working on it.
According to RFC 2328 A.4.1
The
LSTypefield should be located at 4th byte of LSAheader.and the missing LSOptions field should be at 3th.