refactor: don't fill empty metadata slots #32
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some metadata arrays are pretty big (e.g.
EthernetTypeMetadata
has 65536 slots), while only a small subset of the values are filled with actual decoders (e.g. forEthernetTypeMetadata
that is 18 entries).The rest were filled in
func init()
to return error on access. This leads to noticeable startup time delay, as these mappings are pretty big.This change simply leaves not used slots unset (zero value), and the request error values are generated on access to the slot.
Comparing time with
GODEBUG=inittrace=1
on a simple test program which importsgopacket/layers
:before:
after: