add ability to handle pointers in layerString #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR extends the layerString function to recognize fmt.Stringer implementations on pointer receivers and adds a test for dumping embedded pointer fields.
- Add pointer‐receiver Stringer detection in layerString
- Introduce embeddedPointer and embeddingPointer types
- Add TestDumpEmbeddedPointer to verify pointer field handling
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packet.go | Inserted logic in layerString to check for Stringer on the addressable value before falling back to reflection |
| packet_test.go | Defined new pointer‐based structs and TestDumpEmbeddedPointer to validate pointer field dereferencing |
Comments suppressed due to low confidence (2)
packet.go:319
- [nitpick] Consider renaming the variable
ptrto something more descriptive likeaddrValoraddrto clarify that this is an addressable reflect.Value, not a raw pointer.
ptr := v.Addr()
packet.go:317
- The new pointer‐receiver Stringer detection logic isn't covered by existing tests. Add a test for a type that implements fmt.Stringer only on its pointer receiver to verify this branch.
if v.CanInterface() {
mosajjal
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes #113