Feature/add serialize to ipv6 routing #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>
Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>
…ken/gopacket into feature/add-SerializeTo-IPv6Routing
There was a problem hiding this comment.
Pull Request Overview
Adds a SerializeTo method to the IPv6Routing layer so it can implement gopacket.SerializableLayer and be serialized back into bytes.
- Compute total header length (base + routing addresses) and header extension length
- Prepend bytes and fill in NextHeader, HdrExtLen, RoutingType, SegmentsLeft, Reserved, and address list
- Copy each routing IP into the payload area
Comments suppressed due to low confidence (2)
layers/ip6.go:580
- [nitpick] The loop variable
ishadows the receiveri. Rename the index variable (e.g., toidx) to avoid confusion.
for i, ip := range i.SourceRoutingIPs {
layers/ip6.go:567
- There are no unit tests covering
SerializeTo. Consider adding tests for both empty and non-emptySourceRoutingIPsto verify correct serialization.
func (i *IPv6Routing) SerializeTo(b gopacket.SerializeBuffer, opts gopacket.SerializeOptions) error {
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add implementation
SerializeTotoIPv6Routing#106