endian: fix big endian detection #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The prior implementation of Htons attempted big endian detection via
comparison of binary.NativeEndian.String() with binary.BigEndian.String().
It turns out that the former always returns "NativeEndian", hence it
didn't work as intended.
Rewrite endian detection by passing []byte{0x12, 0x34} through
Endian.Uint16(). Add test to ensure that detection works both on little
and big endian CPUs.
|
@mosajjal sorry for messing it up on the first try |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prior implementation of Htons attempted big endian detection via comparison of binary.NativeEndian.String() with binary.BigEndian.String(). It turns out that the former always returns "NativeEndian", hence it didn't work as intended.
Rewrite endian detection by passing []byte{0x12, 0x34} through Endian.Uint16(). Add test to ensure that detection works both on little and big endian CPUs.