Enable decoding/encoding additional RadioTap namespaces and Vendor namespaces #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
layers/radiotap_test.go:31
- Consider adding an assertion to verify that the RadioTapValues slice is non-empty before directly accessing index 0 to avoid potential panics in edge cases.
if rt.RadioTapValues[0].ChannelFrequency != 2412 || rt.RadioTapValues[0].DBMAntennaSignal != -58 || rt.RadioTapValues[0].Antenna != 7 {
layers/dot11_test.go:49
- [nitpick] The change of the Present field from an integer to a slice is significant; please ensure that this new structure is consistently handled across all relevant tests.
Present: []RadioTapPresent{0x86f},
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change to the
RadioTap structlayer, but it need not be (can keep the first RadioTap namespace at the top level at the cost of some extra verbosity in the code).This PR adds enables the package consumer to decode additional RadioTap value namespaces included in some RadioTap packets. Additionally, vendor value namespaces are now supported, though no effort is currently made to decode the vendor-specific values, the vendor namespace payload is simply included as-is for later decoding by the consumer if desired. A new test case is included to cover the additional namespace use case.
Took the opportunity to make the linter a little happier in the RadioTap file.