Skip to content

Potentially invalid use of #ifdef #89

@ssgelm

Description

@ssgelm

In 94ad652, code was added to check for 64-bit time. The following code was added in order to check for the existence of a type:

#ifdef __time64_t

The problem with this, as far as I'm aware, is that you cannot use ifdef to check whether a type has been defined. See further discussion here1. Was there a particular reason this code was added? It breaks builds on 32-bit systems with 64-bit time enabled.

Footnotes

  1. https://stackoverflow.com/questions/6772802/in-c-c-is-there-a-directive-similar-to-ifndef-for-typedefs.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions